RFR: 8342769: HotSpot Windows/gcc port is broken [v14]

[Julian Waters]

On Tue, 10 Dec 2024 05:13:06 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - _WINDOWS && AARCH64 in sharedRuntime.hpp
>>  - AARCH64 in sharedRuntimeRem.cpp
>>  - Refactor sharedRuntime.cpp
>
> src/hotspot/os/windows/sharedRuntimeRem.cpp line 28:
> 
>> 26: #include "runtime/sharedRuntime.hpp"
>> 27: 
>> 28: #ifdef AARCH64
> 
> Shouldn't this also be
> 
> #if defined(_WINDOWS) && defined(AARCH64)
> 
> ?

sharedRuntimeRem.cpp is a Windows only file - Checking for _WINDOWS for a file under os/windows is somewhat redundant

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1877403199