RFR: 8342769: HotSpot Windows/gcc port is broken [v14]

[David Holmes]

On Tue, 10 Dec 2024 06:06:49 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> src/hotspot/os/windows/sharedRuntimeRem.cpp line 28:
>> 
>>> 26: #include "runtime/sharedRuntime.hpp"
>>> 27: 
>>> 28: #ifdef AARCH64
>> 
>> Shouldn't this also be
>> 
>> #if defined(_WINDOWS) && defined(AARCH64)
>> 
>> ?
>
> sharedRuntimeRem.cpp is a Windows only file - Checking for _WINDOWS for a file under os/windows is somewhat redundant

Sorry, missed that. Please ignore.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1877520557