RFR: 8345959: Make JVM_IsStaticallyLinked JVM_LEAF

Jiangli Zhou jiangli at openjdk.org
Thu Dec 12 16:17:45 UTC 2024


On Wed, 11 Dec 2024 23:44:46 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:

>> This is likely fine. I must admit I am not aware of the differences between JVM_ENTRY_NO_ENV and JVM_LEAF, and just picked one that seemed reasonable to me given context and other usages.
>
> Thanks for the quick review, @magicus!
> 
> I didn't catch this details while reviewing https://github.com/openjdk/jdk/commit/a136a85b6f5bbc92727883693c1ce31c37a82fd5 either.

> @jianglizhou please remember the two reviewer rule for hotspot changes and the 24 hour rule for non-trivial changes. When Magnus admits to not knowing the significance of leaf versus non-leaf his one review hardly seems sufficient in any case.
> 
> The change to leaf is of course fine.

@dholmes-ora Thanks for the notes. I handled the change as trivial change. I will observe&follow the hotspot change rule more strictly moving forward.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22685#issuecomment-2539402256


More information about the hotspot-dev mailing list