RFR: 8346714: [ASAN] compressedKlass.cpp reported applying non-zero offset to null pointer [v2]
SendaoYan
syan at openjdk.org
Fri Dec 20 15:12:57 UTC 2024
> Hi all,
> CompressedKlassPointers::sanity_check_after_initialization() src/hotspot/share/oops/compressedKlass.cpp:104:38 reported runtime error: applying non-zero offset 4294967296 to null pointer by clang17 UndefinedBehaviorSanitizer.
>
> The _base initial as nullptr in function CompressedKlassPointers::initialize(address addr, size_t len) shows as below. In C/C++, offsetting a null pointer is undefined behavior. This PR do not change the original logic but eliminate the undefined behaviour in code, the risk is low.
>
> ```c++
> address const end = addr + len;
> if (end <= (address)unscaled_max) {
> _base = nullptr;
> _shift = 0;
SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
case _base to inrptr_t and add the offset, to avoid null check
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22848/files
- new: https://git.openjdk.org/jdk/pull/22848/files/766e09be..6abd26e1
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22848&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22848&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/22848.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22848/head:pull/22848
PR: https://git.openjdk.org/jdk/pull/22848
More information about the hotspot-dev
mailing list