RFR: 8346714: [ASAN] compressedKlass.cpp reported applying non-zero offset to null pointer [v2]

[Martin Doerr]

On Fri, 20 Dec 2024 15:12:57 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Hi all,
>> CompressedKlassPointers::sanity_check_after_initialization() src/hotspot/share/oops/compressedKlass.cpp:104:38 reported runtime error: applying non-zero offset 4294967296 to null pointer by clang17 UndefinedBehaviorSanitizer.
>> 
>> The _base initial as nullptr in function CompressedKlassPointers::initialize(address addr, size_t len) shows as below. In C/C++, offsetting a null pointer is undefined behavior. This PR do not change the original logic but eliminate the undefined behaviour in code, the risk is low.
>> 
>> ```c++
>>     address const end = addr + len;
>>     if (end <= (address)unscaled_max) {
>>       _base = nullptr;
>>       _shift = 0;
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   case _base to inrptr_t and add the offset, to avoid null check

Thanks for fixing the issue! This should work.
In general, I still prefer using `uintptr_t` because `intptr_t` has undefined behavior on overflow. Probably not in this case, here.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22848#pullrequestreview-2517816077