RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v4]

[Evgeny Astigeevich]

On Thu, 1 Feb 2024 11:56:58 GMT, Boris Ulasevich <bulasevich at openjdk.org> wrote:

> Again. The idea is to move to a plain, simple, readable code, if you don't mind

I don't think `subtract_size` is a good name for the function.
Why does it have three parameters? Logically a subtract operation is `a - b`. A reader of the code will have to go to the definition of the function to understand its logic. This means you can save reader's time just putting the code of `subtract_size` in place or giving more meaningful name.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1474638850