RFR: 8324881: ObjectSynchronizer::inflate(Thread* current...) is invoked for non-current thread [v4]
Daniel D. Daugherty
dcubed at openjdk.org
Fri Feb 2 15:21:03 UTC 2024
On Fri, 2 Feb 2024 08:00:39 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> Ummm... Here's the comment line I'm talking about:
>>> I thought you would have to handle `LockingMode == LM_LEGACY && locking_thread->is_lock_owned((address)prev_owner) == true`.
>>
>> and the code that I referred to on L350 is exactly that line of code. Again, what am I missing?
>
> Axel added that line after my comment.
Thanks for figuring out that's what I was missing! You made the comment, Axel changed
the code well below your comment in the PR, GitHub didn't connect the comment and
the code change together to flag anything as "outdated". And most importantly, I missed
that there was a commit made in response to your comment from the history.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17626#discussion_r1476192497
More information about the hotspot-dev
mailing list