RFR: 8320750: Allow a testcase to run with multiple -Xlog [v2]

[Leo Korinth]

On Thu, 8 Feb 2024 08:59:25 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added test, reworked code structure after suggestions from Stefan and Johan
>
> test/jtreg-ext/requires/VMProps.java line 143:
> 
>> 141:         map.put("vm.flagless", this::isFlagless);
>> 142:         map.put("jdk.foreign.linker", this::jdkForeignLinker);
>> 143:         map.putAll(xFlags()); // -Xmx4g -> @requires vm.opt.x.Xmx == "4g" )
> 
> This has a slightly different style than the vmOptFinalFlags:
> 
> map.putAll(xFlags()); // -Xmx4g -> @requires vm.opt.x.Xmx == "4g" )
> 
> vs
> 
> vmOptFinalFlags(map);
> 
> 
> It could be nice to unify the style so that we have:
> 
> vmOptXFlags(map);
> vmOptFinalFlags(map);

In this case I much prefer my functional style of returning a map value instead of mutating a map argument. I feel I will never finish this if I follow the rabbit hole of updating `vmOptFinalFlags(map)`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16824#discussion_r1482712044