RFR: 8320750: Allow a testcase to run with multiple -Xlog [v2]

[Stefan Karlsson]

On Thu, 8 Feb 2024 10:03:50 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> test/jtreg-ext/requires/VMProps.java line 143:
>> 
>>> 141:         map.put("vm.flagless", this::isFlagless);
>>> 142:         map.put("jdk.foreign.linker", this::jdkForeignLinker);
>>> 143:         map.putAll(xFlags()); // -Xmx4g -> @requires vm.opt.x.Xmx == "4g" )
>> 
>> This has a slightly different style than the vmOptFinalFlags:
>> 
>> map.putAll(xFlags()); // -Xmx4g -> @requires vm.opt.x.Xmx == "4g" )
>> 
>> vs
>> 
>> vmOptFinalFlags(map);
>> 
>> 
>> It could be nice to unify the style so that we have:
>> 
>> vmOptXFlags(map);
>> vmOptFinalFlags(map);
>
> In this case I much prefer my functional style of returning a map value instead of mutating a map argument. I feel I will never finish this if I follow the rabbit hole of updating `vmOptFinalFlags(map)`.

I can unify this code after you get this integrated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16824#discussion_r1482751059