RFR: 8320750: Allow a testcase to run with multiple -Xlog [v2]

Leo Korinth lkorinth at openjdk.org
Thu Feb 8 10:15:24 UTC 2024


On Thu, 8 Feb 2024 10:07:32 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> test/jtreg-ext/requires/VMProps.java line 752:
>> 
>>> 750:      */
>>> 751:     private static boolean isXFlag(String flag) {
>>> 752:         return flag.startsWith("-X") && !flag.startsWith("-XX:") && !flag.equals("-X");
>> 
>> `-XX:` is not wrong, but I wonder if this could/should be `-XX` instead.
>
> Arguably `-XXSomeFlag` is a an x flag and not an xx flag, but I will change it.

After looking a bit more at the code, I will keep the original code as the `"-XX:"` is used in many places in VMProps.java

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16824#discussion_r1482719843


More information about the hotspot-dev mailing list