RFR: 8320750: Allow a testcase to run with multiple -Xlog [v2]
Leo Korinth
lkorinth at openjdk.org
Thu Feb 8 10:09:57 UTC 2024
On Thu, 8 Feb 2024 09:00:22 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Added test, reworked code structure after suggestions from Stefan and Johan
>
> test/jtreg-ext/requires/VMProps.java line 752:
>
>> 750: */
>> 751: private static boolean isXFlag(String flag) {
>> 752: return flag.startsWith("-X") && !flag.startsWith("-XX:") && !flag.equals("-X");
>
> `-XX:` is not wrong, but I wonder if this could/should be `-XX` instead.
Arguably `-XXSomeFlag` is a an x flag and not an xx flag, but I will change it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16824#discussion_r1482716346
More information about the hotspot-dev
mailing list