RFR: 8319801: Recursive lightweight locking: aarch64 implementation [v16]

Axel Boldt-Christmas aboldtch at openjdk.org
Tue Feb 13 13:03:07 UTC 2024


On Tue, 13 Feb 2024 12:50:41 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> The condition flags must be correct when leaving `fast_lock` and `fast_unlock`. The test is used to set the proper NE condition when jumping out.
>
> Please add a comment to that effect.

The comments on the labels above is not enough. You would like comments on every branch?
```C++
  // Finish fast lock successfully. MUST branch to with flag == EQ
  Label locked;
  // Finish fast lock unsuccessfully. MUST branch to with flag == NE
  Label slow_path;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16608#discussion_r1487808480


More information about the hotspot-dev mailing list