RFR: 8319801: Recursive lightweight locking: aarch64 implementation [v16]

Andrew Haley aph at openjdk.org
Tue Feb 13 16:32:07 UTC 2024


On Tue, 13 Feb 2024 13:00:24 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Please add a comment to that effect.
>
> The comments on the labels above is not enough. You would like comments on every branch?
> ```C++
>   // Finish fast lock successfully. MUST branch to with flag == EQ
>   Label locked;
>   // Finish fast lock unsuccessfully. MUST branch to with flag == NE
>   Label slow_path;

I guess that's a fair point. Preserving flags across branches is very fragile, but I guess that's the way we've always done it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16608#discussion_r1488202392


More information about the hotspot-dev mailing list