RFR: 8320646: RISC-V: C2 VectorCastHF2F [v2]

[Ludovic Henry]

On Wed, 7 Feb 2024 15:22:09 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you review this patch to add instrinsics for VectorCastHF2F/VectorCastF2HF?
>> Thanks!
>> 
>> ## Test
>> 
>> test/jdk/java/lang/Float/Binary16ConversionNaN.java
>> test/jdk/java/lang/Float/Binary16Conversion.java
>> 
>> hotspot/jtreg/compiler/intrinsics/float16
>> hotspot/jtreg/compiler/vectorization/TestFloatConversionsVectorjava
>> hotspot/jtreg/compiler/vectorization/TestFloatConversionsVectorNaN.java
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add some comments

Small changes.

src/hotspot/cpu/riscv/riscv_v.ad line 3691:

> 3689:   match(Set dst (VectorCastHF2F src));
> 3690:   effect(TEMP_DEF dst, TEMP v0);
> 3691:   format %{ "vfwcvt.f.f.v $dst, $src\t# convert half to single precision"

Unnecessary new-line:
Suggestion:

  format %{ "vfwcvt.f.f.v $dst, $src\t# convert half to single precision" %}

src/hotspot/cpu/riscv/riscv_v.ad line 3706:

> 3704:   match(Set dst (VectorCastF2HF src));
> 3705:   effect(TEMP_DEF dst, TEMP v0, TEMP tmp);
> 3706:   format %{ "vfncvt.f.f.w $dst, $src\t# convert single to half precision"

Unnecessary new-line:
Suggestion:

  format %{ "vfwcvt.f.f.v $dst, $src\t# convert half to single precision" %}

-------------

Marked as reviewed by luhenry (Committer).

PR Review: https://git.openjdk.org/jdk/pull/17698#pullrequestreview-1902878504
PR Review Comment: https://git.openjdk.org/jdk/pull/17698#discussion_r1503852770
PR Review Comment: https://git.openjdk.org/jdk/pull/17698#discussion_r1503853103