RFR: 8321137: Reconsider ICStub alignment [v2]

[Dean Long]

On Mon, 8 Jan 2024 09:43:56 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/code/icBuffer.cpp line 229:
>> 
>>> 227:            p2i(ic_stub), p2i(ic_stub->code_begin()), p2i(rev_stub));
>>> 228:   }
>>> 229: #endif
>> 
>> I think this sanity check would fit better in `new_ic_stub`().
>
> Problem is, `new_ic_stub` can return null on out of memory, so we would need to check that. But I think `new_ic_stub` does not carry its weight, so I just inlined it in new commit, which looks like a good middle ground?

Sure, that's fine.  I still feel like from_destination_address sanity checks should not be in the caller, but should be done at ICStub creation time or when code_begin() is called, but it's not a big deal I guess if ICStub can go away soon.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17277#discussion_r1445262227