RFR: 8322880: Eliminate -Wparentheses warnings in arm32 code [v2]
Kim Barrett
kbarrett at openjdk.org
Tue Jan 9 22:30:14 UTC 2024
> Please review this change to eliminate some -Wparentheses warnings. In most
> cases, this involved simply adding a few parentheses to make some implicit
> operator precedence explicit. Exceptions are:
>
> In the clear_array instruct, removed extraneous parens in a declaration:
> `Label(loop);` => `Label loop;`
>
> In NativeMovConstReg::set_data, changed `&` => `&&`. This is conceptually a
> bug fix, but the old code "accidentally" worked.
>
> Testing: Local (linux-x64) cross-build for linux-arm32. Also ran GHA with
> -Wparentheses enabled along with this and other changes needed to make that
> work.
Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge branch 'master' into arm32-wparentheses
- Fix -Wparentheses warnings in arm32 code
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17300/files
- new: https://git.openjdk.org/jdk/pull/17300/files/d939f43b..00c21d10
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17300&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17300&range=00-01
Stats: 12461 lines in 152 files changed: 9585 ins; 1562 del; 1314 mod
Patch: https://git.openjdk.org/jdk/pull/17300.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17300/head:pull/17300
PR: https://git.openjdk.org/jdk/pull/17300
More information about the hotspot-dev
mailing list