RFR: 8316930: HotSpot should use noexcept instead of throw() [v2]

Julian Waters jwaters at openjdk.org
Thu Jan 11 13:12:55 UTC 2024


On Tue, 26 Sep 2023 07:23:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

> The change from `throw()` to `noexcept` seems reasonable though I assume we have to first approve this via the Hostpot style guide?
> 
> There are places you are adding `noexcept` when there is no `throw()` and that seems inappropriate for this PR - unless they are required because of some transitive rule application?
> 
> Thanks.

Oops, those places where noexcept slipped through are from an experimental branch where I enabled exceptions for HotSpot, they got in by mistake, my apologies. I've moved this to draft for now, since Apple Clang seems to be having a hard time with the noexcept specifiers. Not sure about the Style Guide, maybe I should ask @kimbarrett?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15910#issuecomment-1734982536


More information about the hotspot-dev mailing list