RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v2]
Evgeny Astigeevich
eastigeevich at openjdk.org
Tue Jan 16 18:39:22 UTC 2024
On Tue, 16 Jan 2024 17:55:01 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> Boris Ulasevich has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>>
>> cleanup & test udpdate
>
> src/hotspot/share/code/codeCache.hpp line 469:
>
>> 467: typedef CodeBlobIterator<CodeBlob, AllCodeBlobsFilter, false /* is_relaxed */> AllCodeBlobsIterator;
>> 468:
>> 469: struct CodeCacheSegment {
>
> Would this create a confusion?
> `CodeHeap` consists of blocks and names them `segments`. See `src/hotspot/share/memory/heap.hpp` and `src/hotspot/share/memory/heap.cpp`.
> There is `CodeCache::allocated_segments()` which returns the total number of segments (memory blocks) code heaps use. Also there is `CodeCacheSegmentSize` which defines the size of a memory block for a code heap.
Maybe `CodeHeapInfo` would be better?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1453843195
More information about the hotspot-dev
mailing list