RFR: 8311248: Refactor CodeCache::initialize_heaps to simplify adding new CodeCache segments [v2]
Boris Ulasevich
bulasevich at openjdk.org
Fri Jan 26 10:04:53 UTC 2024
On Tue, 16 Jan 2024 18:36:22 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> src/hotspot/share/code/codeCache.hpp line 469:
>>
>>> 467: typedef CodeBlobIterator<CodeBlob, AllCodeBlobsFilter, false /* is_relaxed */> AllCodeBlobsIterator;
>>> 468:
>>> 469: struct CodeCacheSegment {
>>
>> Would this create a confusion?
>> `CodeHeap` consists of blocks and names them `segments`. See `src/hotspot/share/memory/heap.hpp` and `src/hotspot/share/memory/heap.cpp`.
>> There is `CodeCache::allocated_segments()` which returns the total number of segments (memory blocks) code heaps use. Also there is `CodeCacheSegmentSize` which defines the size of a memory block for a code heap.
>
> Maybe `CodeHeapInfo` would be better?
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17244#discussion_r1467442944
More information about the hotspot-dev
mailing list