RFR: 8324186: AARCH64: Use "dmb.ishst+dmb.ishld" for release barrier

Andrey Turbanov aturbanov at openjdk.org
Mon Jan 22 16:23:32 UTC 2024


On Mon, 22 Jan 2024 01:58:32 GMT, kuaiwei <duke at openjdk.org> wrote:

> Details is https://mail.openjdk.org/pipermail/hotspot-compiler-dev/2024-January/071921.html.
> Using a combined dmb.ish for release barrier will introduce a heavy storeload barrier. Use "dmb.ishst+dmb.ishld" pair instead, we can gain performance improvement on N1 and N2 architecture. The benchmark is test/micro/org/openjdk/bench/vm/compiler/FinalFieldInitialize.java
> Run with ParallelGC to minimalize impact of gc barrier.
> 
> make test TEST="micro:org.openjdk.bench.vm.compiler.FinalFieldInitialize" MICRO="VM_OPTIONS=-XX:+UseParallelGC"
> ...
> FinalFieldInitialize.testAllocWithFinal  thrpt    9  1411.601 ?  6.546  ops/s
> 
> Without the patch
> 
> FinalFieldInitialize.testAllocWithFinal  thrpt    9  1214.575 ? 14.217  ops/s

test/micro/org/openjdk/bench/vm/compiler/FinalFieldInitialize.java line 70:

> 68:   public TObj() {
> 69:     i = 10;
> 70:     l = 100l;

Suggestion:

    l = 100L;

test/micro/org/openjdk/bench/vm/compiler/FinalFieldInitialize.java line 82:

> 80:   public TObjWithFinal() {
> 81:     i = 10;
> 82:     l = 100l;

Suggestion:

    l = 100L;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17511#discussion_r1462100254
PR Review Comment: https://git.openjdk.org/jdk/pull/17511#discussion_r1462100420


More information about the hotspot-dev mailing list