RFR: 8324050: Issue store-store barrier after re-materializing objects during deoptimization [v2]
Vladimir Kozlov
kvn at openjdk.org
Mon Jan 22 21:17:41 UTC 2024
> Added missing store-store barrier when we re-materialize scalar replaced object during deoptimization.
>
> I also removed redundant `#if COMPILER2_OR_JVMCI` guards which were leftover from [JDK-8312579](https://bugs.openjdk.org/browse/JDK-8312579) changes. It added Vector API support to Graal and changed `#ifdef COMPILER2` to these `#if`. But this code is already under these `ifs`.
>
> Tested tier1-3, scope, stress.
>
> No new regression test. I think it is "almost" impossible to hit this issue because there is a lot of VM's runtime code between the code which rematerialize scalar-replaced objects during deoptimization and a code in Interpreter which is executed after deoptimization and which may execute a store instruction that makes these objects accessible by other threads.
Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
Restore COMPILER2_OR_JVMCI changes
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17503/files
- new: https://git.openjdk.org/jdk/pull/17503/files/49d44048..392135ed
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17503&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17503&range=00-01
Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/17503.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17503/head:pull/17503
PR: https://git.openjdk.org/jdk/pull/17503
More information about the hotspot-dev
mailing list