RFR: 8324050: Issue store-store barrier after re-materializing objects during deoptimization [v2]
Aleksey Shipilev
shade at openjdk.org
Mon Jan 22 21:17:42 UTC 2024
On Mon, 22 Jan 2024 21:14:17 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> Added missing store-store barrier when we re-materialize scalar replaced object during deoptimization.
>>
>> I also removed redundant `#if COMPILER2_OR_JVMCI` guards which were leftover from [JDK-8312579](https://bugs.openjdk.org/browse/JDK-8312579) changes. It added Vector API support to Graal and changed `#ifdef COMPILER2` to these `#if`. But this code is already under these `ifs`.
>>
>> Tested tier1-3, scope, stress.
>>
>> No new regression test. I think it is "almost" impossible to hit this issue because there is a lot of VM's runtime code between the code which rematerialize scalar-replaced objects during deoptimization and a code in Interpreter which is executed after deoptimization and which may execute a store instruction that makes these objects accessible by other threads.
>
> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>
> Restore COMPILER2_OR_JVMCI changes
Marked as reviewed by shade (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/17503#pullrequestreview-1837385824
More information about the hotspot-dev
mailing list