RFR: 8314125: RISC-V: implement Base64 intrinsic - encoding [v2]

[Hamlin Li]

On Mon, 1 Jul 2024 17:13:07 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use pure scalar version when rvv is not supported
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 5230:
> 
>> 5228: 
>> 5229:     // vector version
>> 5230:     {
> 
> You should not even generate the vectorized code if `UseRVV` is false. You can then remove https://github.com/openjdk/jdk/pull/19973/files#diff-97f199af6d1c8c17b2fa4f50eb1bbc0081858cc59a899f32792a2d31f933ccc4R5225-R5227 
> 
> Suggestion:
> 
>     if (UseRVV) {

good catch, thanks!

> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 5263:
> 
>> 5261: 
>> 5262:     // scalar version
>> 5263:     __ BIND(ProcessScalar);
> 
> You can move that in the previous block at https://github.com/openjdk/jdk/pull/19973/files#diff-97f199af6d1c8c17b2fa4f50eb1bbc0081858cc59a899f32792a2d31f933ccc4R5260 as it's the only block where it's used.

I think that block is for vector vesion only. Or maybe I misunderstood you?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19973#discussion_r1662575854
PR Review Comment: https://git.openjdk.org/jdk/pull/19973#discussion_r1662577899