RFR: 8314125: RISC-V: implement Base64 intrinsic - encoding [v2]

Ludovic Henry luhenry at openjdk.org
Tue Jul 2 13:57:23 UTC 2024


On Tue, 2 Jul 2024 13:51:02 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 5263:
>> 
>>> 5261: 
>>> 5262:     // scalar version
>>> 5263:     __ BIND(ProcessScalar);
>> 
>> You can move that in the previous block at https://github.com/openjdk/jdk/pull/19973/files#diff-97f199af6d1c8c17b2fa4f50eb1bbc0081858cc59a899f32792a2d31f933ccc4R5260 as it's the only block where it's used.
>
> I think that block is for vector vesion only. Or maybe I misunderstood you?

That `ProcessScalar` Label is only ever jumped to if we're in the `UseRVV` block, so please move that `__ BIND(ProcessScalar)` to L5256, inside the `if (UseRVV) { ... }` block.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19973#discussion_r1662583734


More information about the hotspot-dev mailing list