RFR: 8334738: os::print_hex_dump should optionally print ASCII [v3]

[Thomas Stuefe]

On Wed, 3 Jul 2024 17:34:14 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   exclude test for AIX
>
> This isn't really the area of my expertise, but the patch seems reasonable to me.

Many thanks, @jerboaa !

> src/hotspot/share/runtime/os.cpp line 945:
> 
>> 943: 
>> 944: ATTRIBUTE_NO_ASAN static bool read_safely_from(const uintptr_t* p, uintptr_t* result) {
>> 945:   DEBUG_ONLY(*result = 0xAAAA;)
> 
> It's not clear why this was added. Left-over?

It's intentional, to have an indication for a failing SafeFetch that we in turn fail to recognise.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19835#issuecomment-2208195396
PR Review Comment: https://git.openjdk.org/jdk/pull/19835#discussion_r1665183201