RFR: 8334738: os::print_hex_dump should optionally print ASCII [v3]

[Severin Gehwolf]

On Thu, 4 Jul 2024 06:17:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> src/hotspot/share/runtime/os.cpp line 945:
>> 
>>> 943: 
>>> 944: ATTRIBUTE_NO_ASAN static bool read_safely_from(const uintptr_t* p, uintptr_t* result) {
>>> 945:   DEBUG_ONLY(*result = 0xAAAA;)
>> 
>> It's not clear why this was added. Left-over?
>
> It's intentional, to have an indication for a failing SafeFetch that we in turn fail to recognise.

OK, thanks for the explanation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19835#discussion_r1665309552