RFR: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 [v2]

[Patricio Chilano Mateo]

On Thu, 4 Jul 2024 04:49:53 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Patricio Chilano Mateo has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Coleen's comments
>>  - David's comments
>
> src/hotspot/share/interpreter/oopMapCache.cpp line 179:
> 
>> 177: #ifdef ASSERT
>> 178:   _used = false;
>> 179: #endif
> 
> Nit pre-existing: use of DEBUG_ONLY would be more consistent with later setting of `_used`.

Fixed.

> src/hotspot/share/interpreter/oopMapCache.cpp line 408:
> 
>> 406: 
>> 407: void InterpreterOopMap::resource_copy(OopMapCacheEntry* from) {
>> 408:   // The expectation is that this InterpreterOopMap is a recently created
> 
> s/is a recently/is recently/

Fixed.

> src/hotspot/share/interpreter/oopMapCache.hpp line 136:
> 
>> 134:   // Copy the OopMapCacheEntry in parameter "from" into this
>> 135:   // InterpreterOopMap.  If the _bit_mask[0] in "from" points to
>> 136:   // allocated space (i.e., the bit mask was to large to hold
> 
> Nit pre-existing: s/to/too/

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20012#discussion_r1666856873
PR Review Comment: https://git.openjdk.org/jdk/pull/20012#discussion_r1666856765
PR Review Comment: https://git.openjdk.org/jdk/pull/20012#discussion_r1666856975