RFR: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665 [v2]

Patricio Chilano Mateo pchilanomate at openjdk.org
Fri Jul 5 14:17:10 UTC 2024


On Fri, 5 Jul 2024 12:34:55 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/interpreter/oopMapCache.hpp line 138:
>> 
>>> 136:   // allocated space (i.e., the bit mask was to large to hold
>>> 137:   // in-line), allocate the space from the C heap.
>>> 138:   void resource_copy(OopMapCacheEntry* from);
>> 
>> The name `resource_copy` seems somewhat of a misnomer given it may be C heap. Is it worth changing?
>
> I agree, this should probably be copy_from, and rename the parameter src.  Or something like that.

I also thought about renaming it but ended up leaving it as is in v1. I changed it to Coleen's suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20012#discussion_r1666861013


More information about the hotspot-dev mailing list