RFR: 8334999: RISC-V: implement AES single block encryption/decryption intrinsics [v2]

ArsenyBochkarev duke at openjdk.org
Mon Jul 8 15:24:13 UTC 2024


On Mon, 8 Jul 2024 09:30:36 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> ArsenyBochkarev has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Use t2 directly instead of temp2
>>  - Rename temp1 -> x0
>>  - Left a note on a side effect of generate_vle32_pack4
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 2360:
> 
>> 2358:     generate_aescrypt_round(res, vzero, vtmp1, vtmp2, vtmp3, vtmp4);
>> 2359: 
>> 2360:     generate_vle32_pack2(key, vtmp1, vtmp2);
> 
> Could you add the comment for `key` here as well.

All done!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19960#discussion_r1668842170


More information about the hotspot-dev mailing list