RFR: 8335269: [Graal] occasional timeout in java/lang/StringBuffer/TestSynchronization.java with loom [v3]
Patricio Chilano Mateo
pchilanomate at openjdk.org
Wed Jul 10 20:31:43 UTC 2024
On Wed, 10 Jul 2024 05:25:48 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rename test to ThreadPollOnYield.java
>
> test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java line 39:
>
>> 37: * @requires vm.continuations
>> 38: * @library /test/lib
>> 39: * @run junit/othervm -Xcomp -XX:-TieredCompilation -XX:CompileCommand=inline,*::yield* -XX:CompileCommand=inline,*::*Yield ThreadPollOnYield
>
> Given this forces -Xcomp shouldn't we skip running it when compilation mode is set via jtreg flags?
The test should never fail even with external flags, so if anything it's just extra testing. But I can add vm.flagless if you prefer.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20016#discussion_r1672931556
More information about the hotspot-dev
mailing list