RFR: 8335269: [Graal] occasional timeout in java/lang/StringBuffer/TestSynchronization.java with loom [v3]

[David Holmes]

On Wed, 10 Jul 2024 20:29:19 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> test/jdk/java/lang/Thread/virtual/ThreadPollOnYield.java line 39:
>> 
>>> 37:  * @requires vm.continuations
>>> 38:  * @library /test/lib
>>> 39:  * @run junit/othervm -Xcomp -XX:-TieredCompilation -XX:CompileCommand=inline,*::yield* -XX:CompileCommand=inline,*::*Yield ThreadPollOnYield
>> 
>> Given this forces -Xcomp shouldn't we skip running it when compilation mode is set via jtreg flags?
>
> The test should never fail even with external flags, so if anything it's just extra testing. But I can add vm.flagless if you prefer.

flagless might be going too far as we won't test with other GC's etc. Can we just use `@requires vm.compMode != "Xcomp"` to exclude it from the Xcomp specific testing which is redundant.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20016#discussion_r1673317959