RFR: 8337421: RISC-V: client VM build failure after JDK-8335191

[Hamlin Li]

On Tue, 30 Jul 2024 05:41:45 GMT, Gui Cao <gcao at openjdk.org> wrote:

> Hi, please help review this patch that fix the client VM build failed for riscv.
> 
> Error log for client VM build to see: [JDK-8337421](https://bugs.openjdk.org/browse/JDK-8337421)
> 
> The root cause is that MaxVectorSize is defined in COMPILER2 or JVMCI, which is not included in client mode. In addition to this, I have adjusted the functions related to initialization using UseSHA256Intrinsics, UseSHA512Intrinsics, UseMD5Intrinsics, UseChaCha20Intrinsics, UseSHA1Intrinsics, UseAdler32Intrinsics to be under the control of the COMPILER2 macro.  And made related adjustments in VM_Version::c2_initialize().
> 
> ### Testing
> - [x] linux-riscv client VM fastdebug native build

Thanks for catching. Looks good to me.

Just one minor comment, which is quite subjective, you're on the call.

Suggested changes:


void VM_Version::initialize() {
  common_initialize();
#ifdef COMPILER2
  c2_initialize();
#endif // COMPILER2
}

void VM_Version::common_initialize() {
  ...
}

#ifdef COMPILER2
void VM_Version::c2_initialize() {
  ...
}
#endif // COMPILER2

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20386#pullrequestreview-2206812795