RFR: 8337421: RISC-V: client VM build failure after JDK-8335191 [v2]
Gui Cao
gcao at openjdk.org
Tue Jul 30 07:52:04 UTC 2024
On Tue, 30 Jul 2024 07:00:27 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Thanks for catching. Looks good to me.
>
> Just one minor comment, which is quite subjective, you're on the call.
>
> Suggested changes:
>
> ```
> void VM_Version::initialize() {
> common_initialize();
> #ifdef COMPILER2
> c2_initialize();
> #endif // COMPILER2
> }
>
> void VM_Version::common_initialize() {
> ...
> }
>
> #ifdef COMPILER2
> void VM_Version::c2_initialize() {
> ...
> }
> #endif // COMPILER2
> ```
Thanks for the review. Fixed
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20386#issuecomment-2257695188
More information about the hotspot-dev
mailing list