RFR: 8332689: RISC-V: Use load instead of trampolines [v2]

Robbin Ehn rehn at openjdk.org
Tue Jun 4 11:52:32 UTC 2024


On Tue, 4 Jun 2024 10:54:49 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8332689
>>  - Remove accidental files
>>  - Remove accidental files
>>  - Baseline
>
> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 90:
> 
>> 88: 
>> 89: bool NativeInstruction::is_call_at(address addr) {
>> 90:   return NativeCall::is_at(addr);
> 
> parent class calling into child class?

We have this every where, hotspot is not an OO design, e.g.:
`bool Thread::is_JavaThread_protected(const JavaThread* target)`
Parent class have an method which takes a child as parameter.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1625857951


More information about the hotspot-dev mailing list