RFR: 8332689: RISC-V: Use load instead of trampolines [v2]

[Hamlin Li]

On Tue, 4 Jun 2024 11:49:29 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 90:
>> 
>>> 88: 
>>> 89: bool NativeInstruction::is_call_at(address addr) {
>>> 90:   return NativeCall::is_at(addr);
>> 
>> parent class calling into child class?
>
> We have this every where, hotspot is not an OO design, e.g.:
> `bool Thread::is_JavaThread_protected(const JavaThread* target)`
> Parent class have an method which takes a child as parameter.

You're right, no, it's not for OO design.
But that's not the argument to break it easily.
Maybe in this case (`is_call_at `) it is necessary to do so? or we can find some better way? I'm not sure, I'll have further check.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1625883535