RFR: 8332689: RISC-V: Use load instead of trampolines [v7]

Robbin Ehn rehn at openjdk.org
Fri Jun 7 11:59:15 UTC 2024


On Thu, 6 Jun 2024 20:56:46 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove tmp file
>
> src/hotspot/cpu/riscv/nativeInst_riscv.hpp line 72:
> 
>> 70:   bool is_jump()                            const { return MacroAssembler::is_jump_at(addr_at(0));        }
>> 71:   bool is_call()                            const { return is_call_at(addr_at(0));                        }
>> 72:   static bool is_call_at(address addr);
> 
> Is this indirection of `is_call_at` necessary? seems only is_call is calling is_call_at?

This follows how this was implmented.
Implementation in static method taking an address.
Member methods using forwarding to these static method with it's instruction address.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1631096475


More information about the hotspot-dev mailing list