RFR: 8329141: Obsolete RTM flags and code

[Christian Hagedorn]

On Fri, 7 Jun 2024 02:00:47 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

> Obsolete HotSpot RTM flags which were deprecated in JDK 23.
> RTM related VM code and tests were removed.
> 
> Tested tier1-3,stress,xcomp

Otherwise, looks good to me.

src/hotspot/share/adlc/output_c.cpp line 1617:

> 1615:       }
> 1616: 
> 1617:       if (node->is_ideal_fastlock() && new_inst->is_ideal_fastlock()) {

You should also update the copyright year of this file.

src/hotspot/share/opto/parse1.cpp line 2228:

> 2226:     // the check will fold.
> 2227:     Node* profile_state = makecon(TypeInt::make(ProfileRTM));
> 2228:     Node* opq   = _gvn.transform( new Opaque3Node(C, rtm_state, Opaque3Node::RTM_OPT) );

This was the last (and probably the only ever) use of `Opaque3Nodes`, so you could remove this class as well.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19589#pullrequestreview-2107082285
PR Review Comment: https://git.openjdk.org/jdk/pull/19589#discussion_r1632837314
PR Review Comment: https://git.openjdk.org/jdk/pull/19589#discussion_r1632841502