RFR: 8329141: Obsolete RTM flags and code [v2]

[Vladimir Kozlov]

On Mon, 10 Jun 2024 10:39:53 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed comments, removed Opaque3 node which is now unused
>
> Otherwise, looks good to me.

Thank you, @chhagedorn, for review. I addressed your comments.

> src/hotspot/share/adlc/output_c.cpp line 1617:
> 
>> 1615:       }
>> 1616: 
>> 1617:       if (node->is_ideal_fastlock() && new_inst->is_ideal_fastlock()) {
> 
> You should also update the copyright year of this file.

Done

> src/hotspot/share/opto/parse1.cpp line 2228:
> 
>> 2226:     // the check will fold.
>> 2227:     Node* profile_state = makecon(TypeInt::make(ProfileRTM));
>> 2228:     Node* opq   = _gvn.transform( new Opaque3Node(C, rtm_state, Opaque3Node::RTM_OPT) );
> 
> This was the last (and probably the only ever) use of `Opaque3Nodes`, so you could remove this class as well.

Done

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19589#issuecomment-2158665625
PR Review Comment: https://git.openjdk.org/jdk/pull/19589#discussion_r1633448708
PR Review Comment: https://git.openjdk.org/jdk/pull/19589#discussion_r1633448955