RFR: 8333994: NMT: call stacks should show source information

[Gerard Ziemski]

On Tue, 11 Jun 2024 12:38:09 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> Patch adds printing of source file and line number to NMT call stacks that are printed in detail mode. Useful for hunting down leaks.

There is a following comment in this code that says:

>       // Note: we deliberately omit printing source information here. NativeCallStack::print_on()
>       // can be called thousands of times as part of NMT detail reporting, and source printing
>       // can slow down reporting by a factor of 5 or more depending on platform (see JDK-8296931).

but we are in fact looking up and printing more detail here. Is that comment no longer relevant, or is the slow down that goes with this change insignificant?

-------------

Changes requested by gziemski (Committer).

PR Review: https://git.openjdk.org/jdk/pull/19655#pullrequestreview-2119284529