RFR: 8333994: NMT: call stacks should show source information
Zhengyu Gu
zgu at openjdk.org
Fri Jun 14 21:15:16 UTC 2024
On Fri, 14 Jun 2024 20:59:50 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
> There is a following comment in this code that says:
>
> > ```
> > // Note: we deliberately omit printing source information here. NativeCallStack::print_on()
> > // can be called thousands of times as part of NMT detail reporting, and source printing
> > // can slow down reporting by a factor of 5 or more depending on platform (see JDK-8296931).
> > ```
>
> but we are in fact looking up and printing more detail here. Is that comment no longer relevant, or is the slow down that goes with this change insignificant?
I have the same question. Did dwarf decoder performance improve? If so, could you point me the PR? Thanks!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19655#issuecomment-2168770022
More information about the hotspot-dev
mailing list