RFR: 8332689: RISC-V: Use load instead of trampolines [v10]

Robbin Ehn rehn at openjdk.org
Mon Jun 17 06:48:17 UTC 2024


On Wed, 12 Jun 2024 08:51:33 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Remove tmp file
>>  - Prepare for dynamic NativeCall size
>>  - Only allow one calling convetion, i.e. fixed sized
>>  - Merge branch 'master' into 8332689
>>  - Review comments
>>  - Move shart/far code to cpp
>>  - Cleanup
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/93f3918e...eb30360a
>
> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 60:
> 
>> 58:   };
>> 59: 
>> 60:   address destination(nmethod *nm = nullptr) const;
> 
> unused argument

This pre-exsisting, fixed.

> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 61:
> 
>> 59: 
>> 60:   address destination(nmethod *nm = nullptr) const;
>> 61:   void set_destination(address new_destination);
> 
> unused method

Used in NativeShortCall::reloc_set_destination/NativeShortCall::set_destination_mt_safe:
`NativeShortCallTrampolineStub::at(trampoline_stub_addr)->set_destination(dest)`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642260368
PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642260028


More information about the hotspot-dev mailing list