RFR: 8333994: NMT: call stacks should show source information

[Johan Sjölen]

On Fri, 14 Jun 2024 21:13:05 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> There is a following comment in this code that says:
> 
> > ```
> >   // Note: we deliberately omit printing source information here. NativeCallStack::print_on()
> >   // can be called thousands of times as part of NMT detail reporting, and source printing
> >   // can slow down reporting by a factor of 5 or more depending on platform (see JDK-8296931).
> > ```
> 
> but we are in fact looking up and printing more detail here. Is that comment no longer relevant, or is the slow down that goes with this change insignificant?

If the performance is poor, then I suspect that caching this information would be useful.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19655#issuecomment-2172469670