RFR: 8332689: RISC-V: Use load instead of trampolines [v10]

[Robbin Ehn]

On Wed, 12 Jun 2024 09:39:33 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Remove tmp file
>>  - Prepare for dynamic NativeCall size
>>  - Only allow one calling convetion, i.e. fixed sized
>>  - Merge branch 'master' into 8332689
>>  - Review comments
>>  - Move shart/far code to cpp
>>  - Cleanup
>>  - ... and 5 more: https://git.openjdk.org/jdk/compare/93f3918e...eb30360a
>
> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 114:
> 
>> 112:   // Creation
>> 113:   friend NativeCall* nativeCall_at(address addr);
>> 114:   friend NativeCall* nativeCall_before(address return_address);
> 
> Is these friend declarations necessary?

No, fixed.

> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 321:
> 
>> 319: }
>> 320: 
>> 321: void NativeShortCall::replace_mt_safe(address instr_addr, address code_buffer) {
> 
> seems no usage and necessity of these 2 methods `replace_mt_safe` and `insert `?

Pre-existing, removing them.

> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 331:
> 
>> 329:   // Creation
>> 330:   friend NativeCall* nativeCall_at(address addr);
>> 331:   friend NativeCall* nativeCall_before(address return_address);
> 
> Is these friend declarations necessary?

No, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642327838
PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642329243
PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642328396