RFR: 8332689: RISC-V: Use load instead of trampolines [v11]
Robbin Ehn
rehn at openjdk.org
Mon Jun 17 08:26:17 UTC 2024
On Thu, 13 Jun 2024 20:37:58 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into 8332689
>> - Merge branch 'master' into 8332689
>> - Merge branch 'master' into 8332689
>> - Merge branch 'master' into 8332689
>> - Remove tmp file
>> - Prepare for dynamic NativeCall size
>> - Only allow one calling convetion, i.e. fixed sized
>> - Merge branch 'master' into 8332689
>> - Review comments
>> - Move shart/far code to cpp
>> - ... and 6 more: https://git.openjdk.org/jdk/compare/5d2a19de...bb7249b8
>
> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 109:
>
>> 107:
>> 108: //-----------------------------------------------------------------------------
>> 109: // NativeShortCall
>
> Both Far and Short call here are named `patchable far calls` in the comment in macroAssembler_riscv.hpp.
> So, it will be helpful to unify the naming.
macroAssembler_riscv.hpp/nativeInst_riscv.hpp is the interface specification.
Meaning it should only if so refer to NativeCall.
NativeXXXCall is just an implementation name in the cpp file.
Looking a the comment.... I'll try to make an update.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642397151
More information about the hotspot-dev
mailing list