RFR: 8332689: RISC-V: Use load instead of trampolines [v11]

Robbin Ehn rehn at openjdk.org
Mon Jun 17 08:29:16 UTC 2024


On Thu, 13 Jun 2024 20:26:49 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Merge branch 'master' into 8332689
>>  - Remove tmp file
>>  - Prepare for dynamic NativeCall size
>>  - Only allow one calling convetion, i.e. fixed sized
>>  - Merge branch 'master' into 8332689
>>  - Review comments
>>  - Move shart/far code to cpp
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/5d2a19de...bb7249b8
>
> src/hotspot/cpu/riscv/nativeInst_riscv.cpp line 436:
> 
>> 434:   CodeBlob *code = CodeCache::find_blob(call_addr);
>> 435:   assert(code != nullptr, "Could not find the containing code blob");
>> 436:   address stub_addr = trampoline_stub_Relocation::get_trampoline_for(call_addr, (nmethod*)code);
> 
> should there be an assert like `assert(code->is_nmethod())`?

No, if.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19453#discussion_r1642401847


More information about the hotspot-dev mailing list