RFR: 8332587: RISC-V: secondary_super_cache does not scale well [v10]

[Fei Yang]

On Mon, 24 Jun 2024 08:14:25 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Gui Cao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment and fix population_count
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 3802:
> 
>> 3800:     // Check for wraparound.
>> 3801:     Label skip;
>> 3802:     bge(r_array_length, r_array_index, skip);
> 
> Are you sure this test is correct? I would have thought it would be `bgt`. If length == index, then you must set index to 0. I would have expected this to fail testing.

Good catch! Yes, I agree that we should use `bgt` here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19320#discussion_r1650601267