RFR: 8332587: RISC-V: secondary_super_cache does not scale well [v10]
Gui Cao
gcao at openjdk.org
Mon Jun 24 09:26:17 UTC 2024
On Mon, 24 Jun 2024 08:45:19 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 3802:
>>
>>> 3800: // Check for wraparound.
>>> 3801: Label skip;
>>> 3802: bge(r_array_length, r_array_index, skip);
>>
>> Are you sure this test is correct? I would have thought it would be `bgt`. If length == index, then you must set index to 0. I would have expected this to fail testing.
>
> Good catch! Yes, I agree that we should use `bgt` here.
> Are you sure this test is correct? I would have thought it would be `bgt`. If length == index, then you must set index to 0. I would have expected this to fail testing.
Thanks, I will fix it like `blt(r_array_index,r_array_length,skip);` Linked JBS: https://bugs.openjdk.org/browse/JDK-8334843.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19320#discussion_r1650667024
More information about the hotspot-dev
mailing list