RFR: 8333994: NMT: call stacks should show source information [v5]
Thomas Stuefe
stuefe at openjdk.org
Wed Jun 26 06:36:11 UTC 2024
On Sun, 23 Jun 2024 08:57:26 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> cleanups
>
> src/hotspot/share/nmt/nativeCallStackPrinter.cpp line 49:
>
>> 47: char* store = NEW_ARENA_ARRAY(&_text_storage, char, len + 1);
>> 48: strcpy(store, ss.base());
>> 49: (*cached_frame_text) = store;
>
> Redundant parens
Lets keep those. This seems to be in line with general hotspot syntax.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19655#discussion_r1654206412
More information about the hotspot-dev
mailing list