RFR: JDK-8331732 : [PPC64] Unify and optimize code which converts != 0 to 1 [v6]

Martin Doerr mdoerr at openjdk.org
Fri Jun 28 12:17:49 UTC 2024


On Fri, 28 Jun 2024 10:20:08 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  -  remove assembler header
>>  -  remove assembler header
>
> src/hotspot/cpu/ppc/assembler_ppc.inline.hpp line 426:
> 
>> 424: inline void Assembler::setbcr(Register d, ConditionRegister cr, Condition cc) {
>> 425:    setbcr(d, bi0(cr, cc));
>> 426:  }
> 
> Please adapt indentation. It's a bit off. (See previous code.)

Still one space before `}`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19886#discussion_r1658652902


More information about the hotspot-dev mailing list