RFR: JDK-8331732 : [PPC64] Unify and optimize code which converts != 0 to 1 [v17]

Amit Kumar amitkumar at openjdk.org
Fri Jun 28 18:09:19 UTC 2024


On Fri, 28 Jun 2024 18:02:11 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   default value usage
>
> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2386:
> 
>> 2384: 
>> 2385:   // convert !=0 to 1
>> 2386:   normalize_bool(result, true);
> 
> wait, is build successful with this code change ?

I think you can't specify the parameters arbitrarily like this. If you want to pass "true" then you have to specify the register as well;

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19886#discussion_r1659135752


More information about the hotspot-dev mailing list